Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacks: generate #3627

Merged
merged 72 commits into from
Jan 9, 2025
Merged

Stacks: generate #3627

merged 72 commits into from
Jan 9, 2025

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Dec 5, 2024 •
edited
Loading

Description

Add support for stacks generate cli command

Included changes:

  • added stacks generate cli command
  • added tests for local and remote stacks
  • added cli documentation

In this release, recursive stacks are not yet supported.

RFC: #3313

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

denis256 added 22 commits December 5, 2024 17:03
@denis256
Unit struct update
4cb4199
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
d575b6e
@denis256
Add stack parsing
b7530ca
@denis256
Add cty serialization
47cd721
@denis256
stock go
4641420
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
558f3aa
@denis256
Stack config path
97ec9e5
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
1a966ab
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
78a67b1
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
0a1be85
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
01ecf5d
@denis256
unit struct clone
7c9f8bd
@denis256
stack cli
8928af0
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
9d088fb
@denis256
Merge remote-tracking branch 'origin/main' into tg-432-stack-support
82dde7a
@denis256
stack cli update
bd61393
@denis256
Stack cli commands
fd83fb4
@denis256
stack update
14d2088
@denis256
action update
472aeb9
@denis256
Add cli flags
def9b27
@denis256
stack command
f32fb86
@denis256
tg generate
46f57c2
@yhakbar
Copy link
Collaborator

yhakbar commented Jan 8, 2025

@denis256 , if you don't mind, could you put the stacks command behind an experiment flag for now? Users should have to opt-in to use stacks until we're ready for general usage so that we can feel more comfortable changing the API.

yhakbar
yhakbar reviewed Jan 9, 2025
View reviewed changes
config/stack.go Outdated Show resolved Hide resolved
@denis256 denis256 requested a review from yhakbar January 9, 2025 16:36
yhakbar
yhakbar approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@yhakbar yhakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@denis256 denis256 merged commit e828f1c into main Jan 9, 2025
5 of 6 checks passed
@denis256 denis256 deleted the tg-432-stack-support branch January 9, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhakbar yhakbar yhakbar approved these changes

@levkohimins levkohimins Awaiting requested review from levkohimins levkohimins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis256 @yhakbar